Checkstyle Results
The following document contains the results of Checkstyle 6.11.2 with /Users/pholser/java/junit-quickcheck/target/checkout/conf/src-checkstyle.xml ruleset. rss feed
Summary
Files
Info
Warnings
Errors
73
0
163
0
Rules
Category
Rule
Violations
Severity
coding
DeclarationOrder
2
Warning
HiddenField
ignoreConstructorParameter: "true"
ignoreSetter: "true"
1
Warning
IllegalCatch
6
Warning
IllegalThrows
6
Warning
MagicNumber
ignoreNumbers: "-1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 100"
6
Warning
MultipleStringLiterals
4
Warning
ReturnCount
4
Warning
design
FinalClass
1
Warning
VisibilityModifier
publicMemberPattern: "^$"
3
Warning
header
Header
fileExtensions: "java"
headerFile: "/Users/pholser/java/junit-quickcheck/target/checkout/core/target/checkstyle-header.txt"
ignoreLines: "1, 24"
3
Error
imports
AvoidStarImport
allowStaticMemberImports: "true"
1
Warning
ImportOrder
ordered: "true"
groups: "/^javax?\./,."
separated: "true"
option: "bottom"
87
Warning
UnusedImports
2
Warning
indentation
Indentation
3
Warning
javadoc
JavadocMethod
allowMissingPropertyJavadoc: "true"
allowUndeclaredRTE: "true"
scope: "protected"
allowMissingJavadoc: "true"
1
Warning
JavadocVariable
2
Warning
metrics
ClassDataAbstractionCoupling
2
Warning
ClassFanOutComplexity
3
Warning
NPathComplexity
1
Warning
misc
TrailingComment
1
Warning
naming
MethodName
1
Warning
sizes
FileLength
4
Error
FileLength
4
Error
LineLength
1
Warning
MethodCount
2
Warning
MethodLength
1
Warning
ParameterNumber
9
Warning
whitespace
NoWhitespaceAfter
3
Warning
OperatorWrap
1
Warning
WhitespaceAround
2
Warning
Details
com/pholser/junit/quickcheck/From.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Repeatable' import.
35
com/pholser/junit/quickcheck/Pair.java
Severity
Category
Rule
Message
Line
Warning
javadoc
JavadocVariable
Missing a Javadoc comment.
38
Warning
design
VisibilityModifier
Variable 'first' must be private and have accessor methods.
38
Warning
javadoc
JavadocVariable
Missing a Javadoc comment.
39
Warning
design
VisibilityModifier
Variable 'second' must be private and have accessor methods.
39
com/pholser/junit/quickcheck/Produced.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Retention' import.
34
com/pholser/junit/quickcheck/Property.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.ElementType.METHOD' import.
29
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Retention' import.
33
Warning
coding
MagicNumber
'20' is a magic number.
80
Warning
coding
MagicNumber
'60_000' is a magic number.
86
com/pholser/junit/quickcheck/When.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Retention' import.
31
com/pholser/junit/quickcheck/generator/Also.java
Severity
Category
Rule
Message
Line
Warning
imports
UnusedImports
Unused import - com.pholser.junit.quickcheck.Property.
34
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Retention' import.
36
Warning
javadoc
JavadocMethod
Expected an @return tag.
69
com/pholser/junit/quickcheck/generator/ComponentizedGenerator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.Collections.unmodifiableList' import.
29
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.AnnotatedType' import.
31
Warning
imports
ImportOrder
'org.javaruntype.type.TypeParameter' should be separated from previous imports.
34
com/pholser/junit/quickcheck/generator/Ctor.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'com.pholser.junit.quickcheck.random.SourceOfRandomness' import.
31
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.AnnotatedType' import.
32
com/pholser/junit/quickcheck/generator/Distinct.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Retention' import.
34
com/pholser/junit/quickcheck/generator/Fields.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.stream.Collectors.toList' import.
31
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.AnnotatedType' import.
34
com/pholser/junit/quickcheck/generator/Gen.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.ArrayList' import.
34
Warning
naming
MethodName
Name '_gen' must match pattern '^[a-z][a-zA-Z0-9]*$'.
251
com/pholser/junit/quickcheck/generator/Generator.java
Severity
Category
Rule
Message
Line
Warning
sizes
FileLength
File length is 401 lines (max allowed is 400).
1
Warning
imports
ImportOrder
Wrong order for 'java.math.BigDecimal.ONE' import.
32
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Annotation' import.
41
Warning
imports
ImportOrder
'org.javaruntype.type.TypeParameter' should be separated from previous imports.
51
Warning
sizes
LineLength
Line is longer than 120 characters (found 156).
146
Warning
whitespace
WhitespaceAround
'{' is not followed by whitespace.
382
Warning
whitespace
WhitespaceAround
'}' is not preceded with whitespace.
382
com/pholser/junit/quickcheck/generator/GeneratorConfiguration.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Documented' import.
31
com/pholser/junit/quickcheck/generator/Generators.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.Field' import.
29
com/pholser/junit/quickcheck/generator/Lambdas.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.System.identityHashCode' import.
29
Warning
imports
ImportOrder
Wrong order for 'java.lang.invoke.MethodHandle' import.
36
Warning
whitespace
NoWhitespaceAfter
'{' is followed by whitespace.
88
Warning
coding
IllegalThrows
Throwing 'Throwable' is not allowed.
157
com/pholser/junit/quickcheck/generator/NullAllowed.java
Severity
Category
Rule
Message
Line
Warning
header
Header
Line does not match expected header line of ' The MIT License'.
2
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Retention' import.
9
Warning
coding
MagicNumber
'0.2' is a magic number.
23
com/pholser/junit/quickcheck/generator/Only.java
Severity
Category
Rule
Message
Line
Warning
imports
UnusedImports
Unused import - com.pholser.junit.quickcheck.Property.
34
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Retention' import.
36
com/pholser/junit/quickcheck/generator/Shrink.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.List' import.
29
com/pholser/junit/quickcheck/generator/Size.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Retention' import.
34
com/pholser/junit/quickcheck/internal/CartesianIterator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.ArrayList' import.
30
com/pholser/junit/quickcheck/internal/Comparables.java
Severity
Category
Rule
Message
Line
Warning
indentation
Indentation
'Predicate' have incorrect indentation level 4, expected level should be 8.
36
Warning
metrics
NPathComplexity
NPath Complexity is 72 (max allowed is 20).
58
Warning
coding
ReturnCount
Return count is 6 (max allowed is 4).
58
Warning
indentation
Indentation
'T' have incorrect indentation level 4, expected level should be 8.
59
com/pholser/junit/quickcheck/internal/DefaultMethodHandleMaker.java
Severity
Category
Rule
Message
Line
Warning
header
Header
Line does not match expected header line of ' The MIT License'.
2
Warning
imports
ImportOrder
Wrong order for 'java.lang.invoke.MethodHandle' import.
6
com/pholser/junit/quickcheck/internal/Items.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.Collection' import.
29
com/pholser/junit/quickcheck/internal/Lists.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.ArrayList' import.
34
com/pholser/junit/quickcheck/internal/ParameterSampler.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.List' import.
31
com/pholser/junit/quickcheck/internal/ParameterTypeContext.java
Severity
Category
Rule
Message
Line
Warning
sizes
FileLength
File length is 497 lines (max allowed is 400).
1
Warning
imports
ImportOrder
Wrong order for 'java.lang.String.format' import.
35
Warning
imports
ImportOrder
'org.javaruntype.type.Types.arrayComponentOf' should be separated from previous imports.
37
Warning
imports
ImportOrder
Wrong order for 'com.pholser.junit.quickcheck.From' import.
39
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.AnnotatedArrayType' import.
43
Warning
imports
ImportOrder
'org.javaruntype.type.ExtendsTypeParameter' should be separated from previous imports.
59
Warning
design
FinalClass
Class ParameterTypeContext should be declared as final.
69
Warning
sizes
MethodCount
Total number of methods is 31 (max allowed is 30).
69
Warning
metrics
ClassFanOutComplexity
Class Fan-Out Complexity is 28 (max allowed is 24).
69
Warning
coding
DeclarationOrder
Constructor definition in wrong order.
174
Warning
sizes
ParameterNumber
More than 4 parameters (found 5).
174
Warning
coding
DeclarationOrder
Constructor definition in wrong order.
190
Warning
sizes
ParameterNumber
More than 4 parameters (found 6).
190
com/pholser/junit/quickcheck/internal/PropertyParameterContext.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'com.pholser.junit.quickcheck.When' import.
30
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.AnnotatedElement' import.
31
com/pholser/junit/quickcheck/internal/Ranges.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.String.format' import.
29
Warning
imports
ImportOrder
Wrong order for 'java.math.BigInteger' import.
32
Warning
indentation
Indentation
'int' have incorrect indentation level 4, expected level should be 8.
53
Warning
coding
MagicNumber
'62' is a magic number.
93
Warning
coding
MagicNumber
'62' is a magic number.
93
Warning
coding
MagicNumber
'64' is a magic number.
121
com/pholser/junit/quickcheck/internal/Reflection.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Annotation' import.
36
Warning
imports
ImportOrder
'org.javaruntype.type.Type' should be separated from previous imports.
55
Warning
coding
ReturnCount
Return count is 5 (max allowed is 4).
319
com/pholser/junit/quickcheck/internal/Sequences.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.math.BigDecimal' import.
30
com/pholser/junit/quickcheck/internal/Weighted.java
Severity
Category
Rule
Message
Line
Warning
design
VisibilityModifier
Variable 'item' must be private and have accessor methods.
29
com/pholser/junit/quickcheck/internal/conversion/ConstructorInvokingStringConversion.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'com.pholser.junit.quickcheck.conversion.StringConversion' import.
30
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.Constructor' import.
31
Warning
coding
IllegalCatch
Catching 'Exception' is not allowed.
43
com/pholser/junit/quickcheck/internal/conversion/MethodInvokingStringConversion.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'com.pholser.junit.quickcheck.conversion.StringConversion' import.
30
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.Method' import.
31
Warning
coding
IllegalCatch
Catching 'Exception' is not allowed.
43
com/pholser/junit/quickcheck/internal/conversion/StringConversions.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'com.pholser.junit.quickcheck.conversion.StringConversion' import.
34
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Annotation' import.
39
com/pholser/junit/quickcheck/internal/generator/AbstractGenerationStatus.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.HashMap' import.
31
com/pholser/junit/quickcheck/internal/generator/ArrayGenerator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.math.BigDecimal.ZERO' import.
34
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.AnnotatedType' import.
46
Warning
coding
HiddenField
'distinct' hides a field.
88
com/pholser/junit/quickcheck/internal/generator/CompositeGenerator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.AnnotatedElement' import.
37
com/pholser/junit/quickcheck/internal/generator/ExhaustiveDomainGenerator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.Collections' import.
32
Warning
imports
ImportOrder
Wrong order for 'java.util.Collection' import.
33
Warning
imports
ImportOrder
Wrong order for 'java.util.ArrayList' import.
36
com/pholser/junit/quickcheck/internal/generator/GeneratorRepository.java
Severity
Category
Rule
Message
Line
Warning
sizes
FileLength
File length is 441 lines (max allowed is 400).
1
Warning
imports
ImportOrder
Wrong order for 'java.util.Arrays.asList' import.
34
Warning
imports
AvoidStarImport
Using the '.*' form of import should be avoided - com.pholser.junit.quickcheck.generator.*.
39
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Annotation' import.
44
Warning
imports
ImportOrder
'org.javaruntype.type.TypeParameter' should be separated from previous imports.
61
Warning
sizes
MethodCount
Total number of methods is 31 (max allowed is 30).
63
Warning
metrics
ClassDataAbstractionCoupling
Class Data Abstraction Coupling is 11 (max allowed is 10) classes [, ArrayGenerator, CompositeGenerator, Ctor, EnumGenerator, Fields, LambdaGenerator, LinkedHashSet, MarkerInterfaceGenerator, NullableGenerator, Weighted].
63
Warning
metrics
ClassFanOutComplexity
Class Fan-Out Complexity is 25 (max allowed is 24).
63
Warning
misc
TrailingComment
Don't use trailing comments.
67
com/pholser/junit/quickcheck/internal/generator/LambdaGenerator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'com.pholser.junit.quickcheck.generator.GenerationStatus' import.
30
com/pholser/junit/quickcheck/internal/generator/MarkerInterfaceGenerator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.invoke.MethodHandle' import.
35
Warning
whitespace
NoWhitespaceAfter
'{' is followed by whitespace.
55
Warning
coding
IllegalThrows
Throwing 'Throwable' is not allowed.
99
com/pholser/junit/quickcheck/internal/generator/NullableGenerator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'com.pholser.junit.quickcheck.generator.GenerationStatus' import.
29
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.AnnotatedElement' import.
34
Warning
imports
ImportOrder
'org.javaruntype.type.TypeParameter' should be separated from previous imports.
39
com/pholser/junit/quickcheck/internal/generator/PropertyParameterGenerationContext.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.math.BigDecimal' import.
39
Warning
sizes
ParameterNumber
More than 4 parameters (found 5).
55
com/pholser/junit/quickcheck/internal/generator/SamplingDomainGenerator.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.ArrayList' import.
31
com/pholser/junit/quickcheck/internal/generator/ServiceLoaderGeneratorSource.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.ArrayList' import.
32
com/pholser/junit/quickcheck/internal/sampling/ExhaustiveParameterSampler.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.Math.max' import.
31
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.Array' import.
49
Warning
coding
ReturnCount
Return count is 5 (max allowed is 4).
65
Warning
coding
ReturnCount
Return count is 5 (max allowed is 4).
102
com/pholser/junit/quickcheck/internal/sampling/TupleParameterSampler.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.Arrays' import.
44
com/pholser/junit/quickcheck/random/SourceOfRandomness.java
Severity
Category
Rule
Message
Line
Warning
sizes
FileLength
File length is 404 lines (max allowed is 400).
1
Warning
imports
ImportOrder
Wrong order for 'java.util.concurrent.TimeUnit.SECONDS' import.
29
Warning
imports
ImportOrder
Wrong order for 'java.io.ByteArrayInputStream' import.
33
Warning
whitespace
NoWhitespaceAfter
'{' is followed by whitespace.
402
com/pholser/junit/quickcheck/runner/JUnitQuickcheck.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.ArrayList' import.
33
Warning
imports
ImportOrder
'org.junit.Test' should be separated from previous imports.
36
com/pholser/junit/quickcheck/runner/JUnitQuickcheckTestClass.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.lang.annotation.Annotation' import.
30
Warning
imports
ImportOrder
'org.junit.internal.MethodSorter' should be separated from previous imports.
40
com/pholser/junit/quickcheck/runner/NoValuesSatisfiedPropertyAssumptions.java
Severity
Category
Rule
Message
Line
Warning
header
Header
Missing a header - not enough lines in file.
1
Warning
imports
ImportOrder
'org.junit.internal.AssumptionViolatedException' should be separated from previous imports.
4
com/pholser/junit/quickcheck/runner/PropertyFalsified.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.Arrays' import.
30
Warning
coding
MultipleStringLiterals
The String "Property named '%s' failed%s%n" appears 2 times in the file.
43
Warning
coding
MultipleStringLiterals
The String "With arguments: %s%n" appears 2 times in the file.
44
Warning
coding
MultipleStringLiterals
The String "Seeds for reproduction: %s" appears 2 times in the file.
45
Warning
coding
MultipleStringLiterals
The String ":" appears 2 times in the file.
48
Warning
sizes
ParameterNumber
More than 4 parameters (found 6).
61
com/pholser/junit/quickcheck/runner/PropertyStatement.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.stream.Collectors.toList' import.
29
Warning
imports
ImportOrder
Wrong order for 'java.lang.reflect.Parameter' import.
43
Warning
imports
ImportOrder
'org.junit.internal.AssumptionViolatedException' should be separated from previous imports.
49
Warning
metrics
ClassDataAbstractionCoupling
Class Data Abstraction Coupling is 11 (max allowed is 10) classes [AssertionError, ExhaustiveParameterSampler, NoValuesSatisfiedPropertyAssumptions, PropertyParameterContext, PropertyParameterGenerationContext, PropertyVerifier, Random, ShrinkControl, Shrinker, SourceOfRandomness, TupleParameterSampler].
58
Warning
metrics
ClassFanOutComplexity
Class Fan-Out Complexity is 25 (max allowed is 24).
58
Warning
sizes
ParameterNumber
More than 4 parameters (found 5).
68
Warning
whitespace
OperatorWrap
':' should be on a new line.
104
Warning
sizes
MethodLength
Method length is 44 lines (max allowed is 40).
116
Warning
coding
IllegalCatch
Catching 'Throwable' is not allowed.
157
Warning
sizes
ParameterNumber
More than 4 parameters (found 5).
164
Warning
coding
IllegalThrows
Throwing 'Throwable' is not allowed.
170
com/pholser/junit/quickcheck/runner/PropertyVerifier.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
'org.junit.internal.AssumptionViolatedException' should be separated from previous imports.
32
Warning
sizes
ParameterNumber
More than 4 parameters (found 7).
47
Warning
coding
IllegalThrows
Throwing 'Throwable' is not allowed.
67
Warning
coding
IllegalCatch
Catching 'Throwable' is not allowed.
84
Warning
coding
IllegalCatch
Catching 'Throwable' is not allowed.
88
com/pholser/junit/quickcheck/runner/ShrinkNode.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.Comparator.comparing' import.
30
Warning
imports
ImportOrder
Wrong order for 'java.math.BigDecimal' import.
35
Warning
imports
ImportOrder
'org.junit.runners.model.FrameworkMethod' should be separated from previous imports.
40
Warning
sizes
ParameterNumber
More than 4 parameters (found 7).
56
Warning
sizes
ParameterNumber
More than 4 parameters (found 6).
77
Warning
coding
IllegalThrows
Throwing 'Throwable' is not allowed.
104
com/pholser/junit/quickcheck/runner/Shrinker.java
Severity
Category
Rule
Message
Line
Warning
imports
ImportOrder
Wrong order for 'java.util.ArrayDeque' import.
31
Warning
imports
ImportOrder
'org.junit.runners.model.FrameworkMethod' should be separated from previous imports.
34
Warning
coding
IllegalThrows
Throwing 'Throwable' is not allowed.
69
Warning
coding
IllegalCatch
Catching 'Throwable' is not allowed.
97